Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 9, 2025

Resolved / Related Issues

Omnibar feature will be implemented through circa 3 PRs:

  1. Implementing Omnibar
  2. Implementing BreadcrumbBar
  3. Introducing them to the app

Steps used to test these changes

  1. Open Files UI tests app
  2. Go to Omnibar page
  3. Play around

image

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-Omnibar1 branch 3 times, most recently from 7865b98 to 359fa4d Compare March 15, 2025 06:14
0x5bfa and others added 2 commits March 16, 2025 23:58
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-Omnibar1 branch from 159cb4e to 0af6a1a Compare March 16, 2025 14:58
@yaira2 yaira2 marked this pull request as ready for review March 16, 2025 15:23
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 383d82c into files-community:main Mar 16, 2025
5 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 16, 2025
@0x5bfa 0x5bfa deleted the 5bfa/CQ-Omnibar1 branch March 16, 2025 15:32
@Lamparter
Copy link
Contributor

Amazing! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants